Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add new icons #419

Merged
merged 3 commits into from
Apr 24, 2024
Merged

feat(icons): add new icons #419

merged 3 commits into from
Apr 24, 2024

Conversation

dyhalmeida
Copy link
Contributor

Infos

Task

What is being delivered?

  • Add new icons
  • Generate new icons types

What impacts?

  • Icons package and component

Copy link
Contributor

github-actions bot commented Apr 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-24 20:32 UTC

@felipefialho felipefialho changed the title chore(icons): add new icons feat(icons): add new icons Apr 24, 2024
felipefialho
felipefialho previously approved these changes Apr 24, 2024
Copy link
Contributor

@felipefialho felipefialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyhalmeida This is a feat task, not a chore task

@dyhalmeida dyhalmeida requested a review from igorwessel April 24, 2024 19:39
igorwessel
igorwessel previously approved these changes Apr 24, 2024
Copy link
Contributor

@mauriciomutte mauriciomutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block: I think both icons should be mdi

@dyhalmeida dyhalmeida merged commit 2610836 into main Apr 24, 2024
2 checks passed
@dyhalmeida dyhalmeida deleted the chore/add-new-icons branch April 24, 2024 20:29
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants